fix(igxGrid): Merge user-set pin config with default one. #16467
Conversation
MayaKirova
added
❌ status: awaiting-test
tishko0
added
✅ status: verified
|
@MayaKirova please resolve conflicts and do a pr for 21.0.x |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where user-provided pin configuration would override default pinning configuration values with undefined. The fix ensures that only explicitly set properties in the user configuration replace the defaults, while unset properties retain their default values.
Changes:
- Updated the
pinningsetter to merge user configuration with existing defaults usingObject.assign()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| this.resetCaches(); | ||
| } | ||
| this._pinning = value; | ||
| this._pinning = Object.assign({}, this._pinning, value); |
There was a problem hiding this comment.
The updated pinning configuration merge logic lacks test coverage. Consider adding tests to verify that: 1) partial user configurations correctly merge with defaults, 2) undefined values in user config don't override existing defaults, and 3) explicitly set user values properly replace defaults.
Closes #16464
Merge configs so that if user has set empty config for something, it will not override the default for that config with undefined.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)